Reviewed 9 of 13 files at r1, all commit messages.
Reviewable status: 9 of 13 files reviewed, 3 unresolved discussions (waiting on @wangdayong228)

crates/rpc/rpc-middlewares/src/metrics.rs line 4 at r1 (raw file):

use futures::{future::lazy, FutureExt};
use futures_util::future::BoxFuture;
use jsonrpc_core::Result as RpcResult;

This is a middleware for jsonrpsee framework, recommend directly use Result from jsonrpsee crate

crates/rpc/rpc-builder/Cargo.toml line 45 at r1 (raw file):

tokio = { workspace = true, features = ["full"] }

[dependencies.futures-util]

we should use one crate import style

crates/rpc/rpc-middlewares/Cargo.toml line 18 at r1 (raw file):

jsonrpc-core = { workspace = true }
jsonrpsee = { workspace = true ,features = ["server","ws-client"]}
rustls = { version = "0.21", features = ["dangerous_configuration"] }

use the workspace style

Reviewable status: 9 of 13 files reviewed, 4 unresolved discussions (waiting on @wangdayong228)

Cargo.lock line 1516 at r1 (raw file):

 "futures 0.3.30",
 "futures-util",
 "jsonrpc-core 15.1.0",

this crate should upgraded to 18.0.0 already

Reviewable status: 3 of 13 files reviewed, 4 unresolved discussions (waiting on @Pana)

Cargo.lock line 1516 at r1 (raw file):

Done.

crates/rpc/rpc-builder/Cargo.toml line 45 at r1 (raw file):

Done.

crates/rpc/rpc-middlewares/Cargo.toml line 18 at r1 (raw file):

Done.

crates/rpc/rpc-middlewares/src/metrics.rs line 4 at r1 (raw file):

Done.

Reviewed 1 of 13 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @wangdayong228)

crates/rpc/rpc-middlewares/src/metrics.rs line 4 at r1 (raw file):

delete the commented code

Cargo.lock line 1521 at r2 (raw file):

 "futures 0.3.30",
 "futures-util",
 "jsonrpc-core 18.0.0",

seems jsonrpc-core can be removed from cfx-rpc-middlewares dependencies

crates/rpc/rpc-middlewares/src/throttle.rs line 39 at r2 (raw file):

        let bucket = match self.manager.get(name) {
            Some(bucket) => bucket,
            None => return Ok(()),

If can not get a bucket, seems should return an error ?

crates/rpc/rpc-builder/src/lib.rs line 539 at r2 (raw file):

                ws_server.start(modules.ws.clone().expect("ws server error"))
            });
            return Ok(RpcServerHandle {

maybe both http and ws config are settled, so should not return directly

Reviewable status: 11 of 13 files reviewed, 4 unresolved discussions (waiting on @Pana)

Cargo.lock line 1521 at r2 (raw file):

Done.

crates/rpc/rpc-builder/src/lib.rs line 539 at r2 (raw file):

Done.

crates/rpc/rpc-middlewares/src/metrics.rs line 4 at r1 (raw file):

Done.

crates/rpc/rpc-middlewares/src/throttle.rs line 39 at r2 (raw file):

Done.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wangdayong228)

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wangdayong228)